エディタ設定：インデント設定と行末スペース削り #245
Merged
+9
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
レビューありがとうございます。マージします |
|
（雑談）これおもしろくて、例えば手元で |
m-tmatma
added
refactoring
HoppingTappy
pushed a commit
to HoppingTappy/sakura
that referenced
this pull request
Jun 11, 2019
エディタ設定：インデント設定と行末スペース削り
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.editorconfig 設置により、以下の設定を行います。
主な目的
サクラエディタは経緯的に Visual Studio でコーディングを行ってきた人が多く、Visual Studio ではインデントがタブ文字でありタブ文字が4スペース幅で表示されることが多い（デフォルト）ため、GitHub 上でもその設定が強制されるようにプロジェクトのエディタ設定を行う。これにより今後もコーディングスタイルが安定することが期待できる。
さらに大きな利点としては既存コードのタブ文字が GitHub 上でも4スペース幅表示になるため、手元での Visual Studio でのタブ文字表示幅と同じ見た目でコードを見ることができる。（手元とブラウザ表示で変なズレが出にくくなる）
例
設定適用前
https://github.com/kobake/sakura/blob/b118103375f7a5e2d534c945f841b6def25ffb32/sakura_core/CRegexKeyword.h#L86-L101
設定適用後
https://github.com/kobake/sakura/blob/fa43e940b0fb2d12a7339baa6466983028441e8f/sakura_core/CRegexKeyword.h#L86-L101